Merged Georges Editor branch.

--HG--
branch : gsoc2014-dfighter

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/CMakeLists.txt

@@ -1,11 +1,13 @@
 INCLUDE_DIRECTORIES(  ${CMAKE_CURRENT_BINARY_DIR}
                       ${CMAKE_CURRENT_SOURCE_DIR}
                       ${LIBXML2_INCLUDE_DIR}
-                      ${QT_INCLUDES})
+                      ${QT_INCLUDES}
+					  ${CMAKE_CURRENT_SOURCE_DIR}/../../3rdparty/qtpropertybrowser)
 
 FILE(GLOB SRC *.cpp *.h)
 SET(OVQT_EXT_SYS_SRC  ${CMAKE_CURRENT_SOURCE_DIR}/../../extension_system/iplugin.h
                       ${CMAKE_CURRENT_SOURCE_DIR}/../../extension_system/iplugin_manager.h
+                      ${CMAKE_CURRENT_SOURCE_DIR}/../../extension_system/iplugin_spec.h
 					  ${CMAKE_CURRENT_SOURCE_DIR}/../../extension_system/iplugin_spec.h)
 
 SET(OVQT_PLUG_GEORGES_EDITOR_HDR  georges_editor_plugin.h 
@@ -36,7 +38,7 @@ SOURCE_GROUP("OVQT Extension System" FILES ${OVQT_EXT_SYS_SRC})
 
 ADD_LIBRARY(ovqt_plugin_georges_editor MODULE ${SRC} ${OVQT_PLUG_GEORGES_EDITOR_MOC_SRC} ${OVQT_EXT_SYS_SRC} ${OVQT_PLUG_GEORGES_EDITOR_UI_HDRS} ${OVQT_PLUGIN_GEORGES_EDITOR_RC_SRCS})
 
-TARGET_LINK_LIBRARIES(ovqt_plugin_georges_editor ovqt_plugin_core nelmisc nelgeorges ${QT_LIBRARIES})
+TARGET_LINK_LIBRARIES(ovqt_plugin_georges_editor ovqt_plugin_core nelmisc nelgeorges qt_property_browser ${QT_LIBRARIES})
 
 NL_DEFAULT_PROPS(ovqt_plugin_georges_editor "NeL, Tools, 3D: Object Viewer Qt Plugin: Georges Editor")
 NL_ADD_RUNTIME_FLAGS(ovqt_plugin_georges_editor)

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/actions.cpp

@@ -0,0 +1,103 @@
+// Object Viewer Qt - Georges Editor Plugin - MMORPG Framework <http://dev.ryzom.com/projects/ryzom/>
+// Copyright (C) 2011  Adrian Jaekel <aj at elane2k dot com>
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as
+// published by the Free Software Foundation, either version 3 of the
+// License, or (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+// Project includes
+#include "actions.h"
+#include "formitem.h"
+#include "georgesform_model.h"
+
+// Qt includes
+
+
+// NeL includes
+#include <nel/misc/debug.h>
+#include <nel/misc/file.h>
+#include <nel/misc/o_xml.h>
+#include <nel/georges/u_form_loader.h>
+#include <nel/georges/form.h>
+#include <nel/georges/u_form.h>
+#include <nel/georges/u_type.h>
+
+namespace GeorgesQt 
+{
+
+	CUndoFormArrayRenameCommand::CUndoFormArrayRenameCommand(CGeorgesFormModel *model, CFormItem *item, const QVariant &value, QUndoCommand *parent)
+		: QUndoCommand("Rename Form Array Member", parent), m_model(model), m_item(item)
+	{
+		m_newValue = value.toString();
+	}
+
+	void CUndoFormArrayRenameCommand::redo()
+	{
+		update(true);
+	}
+
+	void CUndoFormArrayRenameCommand::undo()
+	{
+		update(false);
+	}
+
+	void CUndoFormArrayRenameCommand::update(bool redo) 
+	{
+		// Get the parent node
+		const NLGEORGES::CFormDfn *parentDfn;
+		uint indexDfn;
+		const NLGEORGES::CFormDfn *nodeDfn;
+		const NLGEORGES::CType *nodeType;
+		NLGEORGES::CFormElm *node;
+		NLGEORGES::UFormDfn::TEntryType type;
+		bool isArray;
+		bool vdfnArray;
+		NLGEORGES::CForm *form=static_cast<NLGEORGES::CForm*>(m_item->form());
+		NLGEORGES::CFormElm *elm = static_cast<NLGEORGES::CFormElm*>(&form->Elements);
+
+		nlverify ( elm->getNodeByName (m_item->formName().c_str (), &parentDfn, indexDfn, &nodeDfn, &nodeType, &node, type, isArray, vdfnArray, true, NLGEORGES_FIRST_ROUND) );
+		if (node)
+		{
+			std::string tmpName;
+			node->getFormName(tmpName);
+
+			NLGEORGES::CFormElmArray* array = static_cast<NLGEORGES::CFormElmArray*> (node->getParent ());
+
+			// In the redo stage save the old value, just in case.
+			if(redo)
+			{
+				// If the name of the element is empty then give it a nice default.
+				if(array->Elements[m_item->structId()].Name.empty())
+				{
+					m_oldValue.append("#");
+					m_oldValue.append(QString("%1").arg(m_item->structId()));
+				}
+				else
+				{
+					m_oldValue = QString::fromStdString(array->Elements[m_item->structId()].Name);
+				}
+			}
+
+			QString value;
+			if(redo)
+				value = m_newValue;
+			else
+				value = m_oldValue;
+
+
+			array->Elements[m_item->structId()].Name = value.toStdString();
+			m_item->setName(value.toStdString());
+
+			m_model->emitDataChanged(m_model->index(m_item->row(), 0, m_item));
+		}
+	}
+}

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/actions.h

@@ -0,0 +1,48 @@
+// Object Viewer Qt - Georges Editor Plugin - MMORPG Framework <http://dev.ryzom.com/projects/ryzom/>
+// Copyright (C) 2011  Adrian Jaekel <aj at elane2k dot com>
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as
+// published by the Free Software Foundation, either version 3 of the
+// License, or (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+#ifndef ACTIONS_H
+#define ACTIONS_H
+
+#include <QtGui/QUndoCommand>
+#include <QModelIndex>
+
+namespace GeorgesQt 
+{
+	class CFormItem;
+	class CGeorgesFormModel;
+
+	class CUndoFormArrayRenameCommand : public QUndoCommand
+	{
+	public:
+		CUndoFormArrayRenameCommand(CGeorgesFormModel *model, CFormItem *item, const QVariant &value, QUndoCommand *parent = 0);
+		~CUndoFormArrayRenameCommand() {}
+
+		void redo();
+		void undo();
+
+		void update(bool redo);
+
+	protected:
+		CFormItem *m_item;
+		CGeorgesFormModel *m_model;
+		
+		QString m_newValue;
+		QString m_oldValue;
+	};
+}
+
+#endif // ACTIONS_H

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/formdelegate.cpp

@@ -38,6 +38,8 @@
 #include "georgesform_proxy_model.h"
 #include "formitem.h"
 
+#if 0
+
 namespace GeorgesQt 
 {
 
@@ -277,3 +279,5 @@ namespace GeorgesQt
 		editor->setGeometry(r);
 	}
 } /* namespace GeorgesQt */
+
+#endif // 0

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/formdelegate.h

@@ -19,6 +19,8 @@
 
 #include <QStyledItemDelegate>
 
+#if 0 
+
 namespace GeorgesQt 
 {
 
@@ -38,4 +40,6 @@ namespace GeorgesQt
 	};
 
 }
+#endif // 0
+
 #endif // FORMDELEGATE_H

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/formitem.cpp

@@ -14,27 +14,26 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-#include "stdpch.h"
+// Project includes
 #include "formitem.h"
+#include "actions.h"
+#include "georges_editor_form.h"
 
 // Qt includes
+#include <QIcon>
 
 // NeL includes
 #include <nel/misc/o_xml.h>
+#include <nel/misc/debug.h>
 #include <nel/georges/u_type.h>
 #include <nel/georges/form.h>
 
+using namespace NLGEORGES;
+
 namespace GeorgesQt 
 {
-
+	CFormItem::CFormItem()
-	CFormItem::CFormItem(NLGEORGES::UFormElm* elm, const QList<QVariant> &data, CFormItem *parent,
-		NLGEORGES::UFormElm::TWhereIsValue wV, NLGEORGES::UFormElm::TWhereIsNode wN) 
 	{
-		parentItem = parent;
-		itemData = data;
-		formElm = elm;
-		whereV = wV;
-		whereN = wN;
 	}
 
 	CFormItem::~CFormItem() 
@@ -60,12 +59,14 @@ namespace GeorgesQt
 	int CFormItem::columnCount() const 
 	{
 		//nlinfo("columnCount %d",itemData.count());
-		return itemData.count();
+		//return itemData.count();
+		return 1;
 	}
 
 	QVariant CFormItem::data(int column) const 
 	{
-		return itemData.value(column);
+		//return itemData.value(column);
+		return QVariant(_Name.c_str());
 	}
 
 	CFormItem *CFormItem::parent()
@@ -83,81 +84,149 @@ namespace GeorgesQt
 
 	bool CFormItem::setData(int column, const QVariant &value) 
 	{
-		if (column < 0 || column >= itemData.size())
+		nlwarning("This should not be called anymore.");
+		return false;
+	}
+
+	bool CFormItem::isEditable(int column)
+	{
+		// Ensure only valid types can be edited.
+		if(_Type == Null)
 			return false;
 
-		// TODO: default values
+		// Make sure only the first column (name) can be editted.
-		if (!formElm)
+		if (column != 0)
 			return false;
 
-		itemData[column] = value;
+		if(isArrayMember())
-		if (formElm->isAtom()) 
+			return true;
+
+		return false;
+	}
+
+	bool CFormItem::isArray()
 	{
-			const NLGEORGES::UType *type = formElm->getType();
+		// If it wasn't a root node then lets check the node type.
-			if (type) 
+		const NLGEORGES::CFormDfn *parentDfn;
+		uint indexDfn;
+		const NLGEORGES::CFormDfn *nodeDfn;
+		const NLGEORGES::CType *nodeType;
+		NLGEORGES::CFormElm *node;
+		NLGEORGES::UFormDfn::TEntryType type;
+		bool array;
+		bool parentVDfnArray;
+		NLGEORGES::CForm *form = static_cast<CForm*>(m_form);
+		NLGEORGES::CFormElm *elm = static_cast<CFormElm*>(&form->getRootNode());
+		nlverify ( elm->getNodeByName (_FormName.c_str(), &parentDfn, indexDfn,
+                   &nodeDfn, &nodeType, &node, type, array, parentVDfnArray, true, NLGEORGES_FIRST_ROUND) );
+
+		if(array && node)
+			return true;
+
+		return false;
+	}
+
+	bool CFormItem::isArrayMember()
+	{
+		CFormItem *parent = this->parent();
+
+		// If it wasn't a root node then lets check the node type.
+		const NLGEORGES::CFormDfn *parentDfn;
+		uint indexDfn;
+		const NLGEORGES::CFormDfn *nodeDfn;
+		const NLGEORGES::CType *nodeType;
+		NLGEORGES::CFormElm *parentNode;
+		NLGEORGES::UFormDfn::TEntryType type;
+		bool array;
+		bool parentVDfnArray;
+		NLGEORGES::CForm *form = static_cast<CForm*>(m_form);
+		NLGEORGES::CFormElm *elm = static_cast<CFormElm*>(&form->getRootNode());
+		nlverify ( elm->getNodeByName (parent->formName ().c_str (), &parentDfn, indexDfn,
+                   &nodeDfn, &nodeType, &parentNode, type, array, parentVDfnArray, true, NLGEORGES_FIRST_ROUND) );
+
+		if(array && parentNode)
+			return true;
+
+		return false;
+	}
+
+	QIcon CFormItem::getItemImage(CFormItem *rootItem)
 	{
-				switch (type->getType()) 
+		if(_Type == CFormItem::Null)
 		{
-				case NLGEORGES::UType::UnsignedInt:
+				return QIcon(":/images/root.ico");
-				case NLGEORGES::UType::SignedInt:
+		}
-				case NLGEORGES::UType::Double:
+		else if(_Type == CFormItem::Form)
-				case NLGEORGES::UType::String:
-					if (parentItem->formElm->isArray())
 		{
-						//((NLGEORGES::CFormElm*)parentItem->formElm);//->arrayInsertNodeByName(
+			// If the parent is the root item then this is the content.
-						//if(parentItem->formElm->getArrayNode(elmName, num))
+			if(parentItem == rootItem)
-						//{
+				return QIcon(":/images/root.ico");
-						//}
+
+			// If it wasn't a root node then lets check the node type.
+			const NLGEORGES::CFormDfn *parentDfn;
+			uint indexDfn;
+			const NLGEORGES::CFormDfn *nodeDfn;
+			const NLGEORGES::CType *nodeType;
+			NLGEORGES::CFormElm *node;
+			NLGEORGES::UFormDfn::TEntryType type;
+			bool array;
+			bool parentVDfnArray;
+			NLGEORGES::CForm *form = static_cast<CForm*>(m_form);
+			NLGEORGES::CFormElm *elm = static_cast<CFormElm*>(&form->getRootNode());
+			nlverify ( elm->getNodeByName (_FormName.c_str(), &parentDfn, indexDfn, &nodeDfn, &nodeType, &node, type, array, parentVDfnArray, true, NLGEORGES_FIRST_ROUND) );
 
-						bool ok;
+			if(array)
-						// TODO: the node can be renamed from eg "#0" to "foobar"
-						int arrayIndex = itemData[0].toString().remove("#").toInt(&ok);
-						if(ok)
 			{
-							NLGEORGES::UFormElm *elmt = 0;
+				return QIcon(":/images/array.ico");
-							if(parentItem->formElm->getArrayNode(&elmt, arrayIndex) && elmt)
+			}
+			else
 			{
-								if (elmt->isAtom()) 
+				if(type == NLGEORGES::UFormDfn::EntryType)
 				{
-									((NLGEORGES::CFormElmAtom*)elmt)->setValue(value.toString().toUtf8().constData());
+					if(parentDfn)
-									nldebug(QString("array element string %1 %2")
+					{
-									.arg(itemData[0].toString()).arg(value.toString())
+						// Not sure what the hell to do with this. Gets filename from parent dfn?
-									.toUtf8().constData());
-								}
-							}
 					}
+					return QIcon(":/images/zfee51.ico");
 				}
-					else
+				else if(type == NLGEORGES::UFormDfn::EntryDfn)
 				{
-						if(parentItem->formElm->setValueByName(
+					if(parentDfn)
-							value.toString().toUtf8().constData(),
-							itemData[0].toString().toUtf8().constData()))
 					{
-							nldebug(QString("string %1 %2")
+						// Not sure what the hell to do with this. Gets filename from parent dfn?
-							.arg(itemData[0].toString()).arg(value.toString())
-							.toUtf8().constData());
 					}
-						else
+					return QIcon(":/images/struct.ico");
+				}
+				else if(type == NLGEORGES::UFormDfn::EntryVirtualDfn)
 				{
-							nldebug(QString("FAILED string %1 %2")
+					if(node)
-							.arg(itemData[0].toString()).arg(value.toString())
+					{
-							.toUtf8().constData());
+						// Not sure what the hell to do with this. Gets filename from parent dfn?
+						std::string dfnName;
+						NLMISC::safe_cast<NLGEORGES::CFormElmVirtualStruct*>(node)->getDfnName(dfnName);
+						// return dfnName.c_str() ?
 					}
+					return QIcon(":/images/vstruct.ico");
 				}
-					break;
-				case NLGEORGES::UType::Color:
-					nldebug("Color is TODO");
-					break;
-				default:
-					break;
 			}
+			//return QIcon(":/images/struct.ico");
 		}
+		return QIcon();
 	}
-		else
+
+	CFormItem *CFormItem::add (TSub type, const char *name, uint structId, const char *formName, uint slot, NLGEORGES::UForm *formPtr)
     {
-			nldebug("setting sth other than Atom");
+		CFormItem *newNode = new CFormItem();
-		}
+        newNode->_Type = type;
-		//formElm->setValueByName();
+        newNode->_Name = name;
-		return true;
+        newNode->parentItem = this;
+        newNode->_StructId = structId;
+        newNode->_FormName = formName;
+        newNode->_Slot  = slot;		
+		newNode->m_form = formPtr;
+
+        appendChild(newNode);
+        return newNode;
     }
+
 }

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/formitem.h

@@ -18,6 +18,7 @@
 #define FORMITEM_H
 
 // NeL includes
+#include <nel/georges/u_form.h>
 #include <nel/georges/u_form_elm.h>
 
 // Qt includes
@@ -28,17 +29,25 @@ namespace GeorgesQt
 {
 
 	class CFormItem
-
 	{
 	public:
-		CFormItem(NLGEORGES::UFormElm *elm, const QList<QVariant> &data, 
+		// What is the sub object ?
-			CFormItem *parent = 0,
+        enum TSub
-			NLGEORGES::UFormElm::TWhereIsValue = NLGEORGES::UFormElm::ValueForm, 
+        {
-			NLGEORGES::UFormElm::TWhereIsNode = NLGEORGES::UFormElm::NodeForm);
+                Null,           // Nothing in this node (root ?)
+                Header,         // Header node
+                Type,           // This node is a type
+                Dfn,            // This node is a dfn
+                Form,           // This node is a form
+        };
+
+		CFormItem();
 		~CFormItem();
 
 		void appendChild(CFormItem *child);
 
+        CFormItem *add (TSub type, const char *name, uint structId, const char *formName, uint slot, NLGEORGES::UForm *formPtr);
+
 		CFormItem *child(int row);
 		int childCount() const;
 		int columnCount() const;
@@ -46,23 +55,36 @@ namespace GeorgesQt
 		int row() const;
 		CFormItem *parent();
 		bool setData(int column, const QVariant &value);
-		NLGEORGES::UFormElm* getFormElm() {return formElm;}
+
-		NLGEORGES::UFormElm::TWhereIsValue valueFrom() 
+		TSub nodeType() { return _Type; }
-		{
+		std::string formName() { return _FormName; }
-			return whereV;
+		
-		}
+		std::string name() { return _Name; }
-		NLGEORGES::UFormElm::TWhereIsNode nodeFrom() 
+		void setName(std::string name) { _Name = name; }
-		{
+
-			return whereN;
+		uint structId() { return _StructId; }
-		}
+
+		NLGEORGES::UForm *form() { return m_form; }
+
+		bool isEditable(int column);
+		bool isArray();
+		bool isArrayMember();
+
+		QIcon getItemImage(CFormItem *rootItem);
 
     private:
 		QList<CFormItem*> childItems;
 		QList<QVariant> itemData;
 		CFormItem *parentItem;
 		NLGEORGES::UFormElm* formElm;
-		NLGEORGES::UFormElm::TWhereIsValue whereV;
+		NLGEORGES::UForm *m_form;
-		NLGEORGES::UFormElm::TWhereIsNode whereN;
+
+		uint                                                            _StructId;
+        std::string                                                     _Name;
+        std::string                                                     _FormName;
+        TSub                                                            _Type;
+        uint                                                            _Slot;
+
 	}; // CFormItem
 
 }

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georges_editor.qrc

@@ -1,5 +1,12 @@
 <RCC>
   <qresource>
+    <file>images/array.ico</file>
+    <file>images/header.ico</file>
+    <file>images/hold.ico</file>
+    <file>images/root.ico</file>
+    <file>images/struct.ico</file>
+    <file>images/vstruct.ico</file>
+    <file>images/zfee51.ico</file>
     <file>images/ic_nel_georges_editor.png</file>
   </qresource>
 </RCC>

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georges_editor_form.cpp

@@ -36,6 +36,7 @@
 
 namespace GeorgesQt
 {
+	QUndoStack *GeorgesEditorForm::UndoStack = NULL;
 
 	GeorgesEditorForm::GeorgesEditorForm(QWidget *parent)
 		: QMainWindow(parent),
@@ -62,7 +63,7 @@ namespace GeorgesQt
 		m_mainDock->setDockNestingEnabled(true);
 		layout->addWidget(m_mainDock);
 
-		m_undoStack = new QUndoStack(this);
+		UndoStack = new QUndoStack(this);
 
 		Core::MenuManager *menuManager = Core::ICore::instance()->menuManager();
 		m_openAction = menuManager->action(Core::Constants::OPEN);
@@ -115,7 +116,7 @@ namespace GeorgesQt
 
 	QUndoStack *GeorgesEditorForm::undoStack() const
 	{
-		return m_undoStack;
+		return UndoStack;
 	}
 
 	void GeorgesEditorForm::open()
@@ -212,7 +213,7 @@ namespace GeorgesQt
         }
 
         CGeorgesTreeViewDialog *dock = new CGeorgesTreeViewDialog(m_mainDock);
-        dock->setUndoStack(m_undoStack);
+        dock->setUndoStack(UndoStack);
         m_lastActiveDock = dock;
         m_dockedWidgets.append(dock);
 

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georges_editor_form.h

@@ -38,6 +38,8 @@ public:
 
 	QUndoStack *undoStack() const;
 
+	static QUndoStack *UndoStack;
+
 public Q_SLOTS:
 	void open();
 	void loadFile(const QString fileName);
@@ -54,7 +56,6 @@ private:
 	void readSettings();
 	void writeSettings();
 
-	QUndoStack *m_undoStack;
 	Ui::GeorgesEditorForm m_ui;
 
 	CGeorgesDirTreeDialog *m_georgesDirTreeDialog;

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georges_treeview_dialog.cpp

@@ -14,14 +14,7 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-#include "stdpch.h"
 #include "georges_treeview_dialog.h"
-#include "georges.h"
-#include "georgesform_model.h"
-#include "georgesform_proxy_model.h"
-#include "formitem.h"
-#include "formdelegate.h"
-#include "expandable_headerview.h"
 
 // Qt includes
 #include <QtGui/QWidget>
@@ -43,6 +36,14 @@
 #include "../core/icore.h"
 #include "../core/core_constants.h"
 
+// Project includes
+#include "georges.h"
+#include "georgesform_model.h"
+#include "georgesform_proxy_model.h"
+#include "formitem.h"
+#include "formdelegate.h"
+#include "expandable_headerview.h"
+
 using namespace NLMISC;
 using namespace NLGEORGES;
 
@@ -71,23 +72,14 @@ namespace GeorgesQt
 		m_ui.treeView->header()->setStretchLastSection(true);
 		m_ui.treeViewTabWidget->setTabEnabled (2,false);
 
-		m_ui.checkBoxParent->setStyleSheet("background-color: rgba(0,255,0,30)");
-		m_ui.checkBoxDefaults->setStyleSheet("background-color: rgba(255,0,0,30)");
 		m_form = 0;
 
-		FormDelegate *formdelegate = new FormDelegate(this);
+        m_ui.treeView->setContextMenuPolicy(Qt::CustomContextMenu);
-		m_ui.treeView->setItemDelegateForColumn(1, formdelegate);
-
-		// Set up custom context menu.
-		setContextMenuPolicy(Qt::CustomContextMenu);
-		connect(this, SIGNAL(customContextMenuRequested(const QPoint&)), this, SLOT(showContextMenu(const QPoint&)));
 
+        connect(m_ui.treeView, SIGNAL(customContextMenuRequested(const QPoint&)),
+                this, SLOT(showContextMenu(const QPoint&)));
 		connect(m_ui.treeView, SIGNAL(doubleClicked (QModelIndex)),
 			this, SLOT(doubleClicked (QModelIndex)));
-		connect(m_ui.checkBoxParent, SIGNAL(toggled(bool)),
-			this, SLOT(filterRows()));
-		connect(m_ui.checkBoxDefaults, SIGNAL(toggled(bool)),
-			this, SLOT(filterRows()));
 		connect(m_header, SIGNAL(headerClicked(int)),
 			this, SLOT(headerClicked(int)));
 	}
@@ -116,30 +108,30 @@ namespace GeorgesQt
 
     NLGEORGES::CForm* CGeorgesTreeViewDialog::getFormByName(const QString formName)
 	{
-		if(NLMISC::CPath::exists(formName.toUtf8().constData()))
+		if(NLMISC::CPath::exists(formName.toStdString()))
 		{
-            //NLGEORGES::CForm *form = dynamic_cast<NLGEORGES::CForm*>(m_georges->loadForm(formName.toUtf8()));
+		    //NLGEORGES::CForm *form = dynamic_cast<NLGEORGES::CForm*>(m_georges->loadForm(formName.toStdString()));
-            return (NLGEORGES::CForm *)m_georges->loadForm(formName.toUtf8().constData());
+		    return (NLGEORGES::CForm *)m_georges->loadForm(formName.toStdString());
 		}
 		//else
 		//{
 		//	CForm *form = 0;
 		//	// Load the DFN
-		//	std::string extStr = NLMISC::CFile::getExtension( formName.toUtf8() );
+		//	std::string extStr = NLMISC::CFile::getExtension( formName.toStdString() );
 		//	QString dfnName = QString("%1.dfn").arg(extStr.c_str());
 		//	UFormDfn *formdfn;
-		//	if (NLMISC::CPath::exists(dfnName.toUtf8()))
+		//	if (NLMISC::CPath::exists(dfnName.toStdString()))
 		//	{
-		//		formdfn = _georges->loadFormDfn (dfnName.toUtf8());
+		//		formdfn = _georges->loadFormDfn (dfnName.toStdString());
 		//		if (!formdfn)
 		//		{
-		//			nlwarning("Failed to load dfn: %s", dfnName.toUtf8());
+		//			nlwarning("Failed to load dfn: %s", dfnName.toStdString().c_str());
 		//			return 0;
 		//		}
 		//	}
 		//	else
 		//	{
-		//		nlwarning("Cannot find dfn: %s", dfnName.toUtf8());
+		//		nlwarning("Cannot find dfn: %s", dfnName.toStdString().c_str());
 		//		return 0;
 		//	}
 
@@ -155,20 +147,20 @@ namespace GeorgesQt
 		//	}
 		//	return form;
 		//}
-        nlinfo("File '%s' does not exist!", formName.toUtf8().constData());
+		nlinfo("File '%s' does not exist!", formName.toStdString().c_str());
 		return 0;
 	}
 
     NLGEORGES::CForm* CGeorgesTreeViewDialog::getFormByDfnName(const QString dfnName)
     {
-        if(NLMISC::CPath::exists(dfnName.toUtf8().constData()))
+		if(NLMISC::CPath::exists(dfnName.toStdString()))
 		{
 		    // Create a new form object.
 		    NLGEORGES::CForm *form = new NLGEORGES::CForm();
 		    m_form = form;
 
 		    // Retrieve a copy of the root definition.
-            NLGEORGES::CFormDfn *formDfn = dynamic_cast<NLGEORGES::CFormDfn *>(m_georges->loadFormDfn(dfnName.toUtf8().constData()));
+		    NLGEORGES::CFormDfn *formDfn = dynamic_cast<NLGEORGES::CFormDfn *>(m_georges->loadFormDfn(dfnName.toStdString()));
 
 		    // Next we'll use the root node to build a new form.
 		    NLGEORGES::CFormElmStruct *fes = dynamic_cast<NLGEORGES::CFormElmStruct *>(getRootNode(0));
@@ -183,7 +175,7 @@ namespace GeorgesQt
 
 		    return form;
 		}
-        nlinfo("File '%s' does not exist!", dfnName.toUtf8().constData());
+		nlinfo("File '%s' does not exist!", dfnName.toStdString().c_str());
 		return NULL;
     }
 
@@ -218,6 +210,7 @@ namespace GeorgesQt
 		UFormElm *root = 0;
 		root = &m_form->getRootNode();
 
+		// Extract the parent forms into the list of parents in the dialog.
 		QStringList parents;
 		uint cnt = form->getParentCount();
 		for (uint i = 0; i < cnt /*form->getParentCount()*/; i++)
@@ -226,6 +219,7 @@ namespace GeorgesQt
 			parents << u->getFilename().c_str();
 		}
 
+		// Exact the comment box for the dialog.
 		QString comments;
 		comments = m_form->getComment().c_str();
 
@@ -249,22 +243,15 @@ namespace GeorgesQt
 		nlinfo("typ's %d",deps["typ"].count());
 		nlinfo("dfn's %d",deps["dfn"].count());
 
-		//nlwarning(strList.join(";").toUtf8());
+		//nlwarning(strList.join(";").toStdString().c_str());
 		if (root) 
 		{
 			loadedForm = m_form->getFilename().c_str();
 
-			CGeorgesFormModel *model = new CGeorgesFormModel(root,deps,comments,parents,m_header->expanded());
+			CGeorgesFormModel *model = new CGeorgesFormModel(m_form,deps,comments,parents,m_header->expanded());
-			CGeorgesFormProxyModel *proxyModel = new CGeorgesFormProxyModel();
+			m_ui.treeView->setModel(model);
-			proxyModel->setSourceModel(model);
-			m_ui.treeView->setModel(proxyModel);
 			m_ui.treeView->expandAll();
-			// this is a debug output row
-			m_ui.treeView->hideColumn(3);
 
-			filterRows();
-
-		//		//_ui.treeView->setRowHidden(0,QModelIndex(),true);
 			connect(model, SIGNAL(dataChanged(const QModelIndex, const QModelIndex)),
 				this, SLOT(modifiedFile()));
 
@@ -276,12 +263,11 @@ namespace GeorgesQt
 	void CGeorgesTreeViewDialog::addParentForm(QString parentFormNm)
 	{
 		// Try to load the form
-		NLGEORGES::UForm *uParentForm = m_georges->loadForm(parentFormNm.toUtf8().constData());
+		NLGEORGES::UForm *uParentForm = m_georges->loadForm(parentFormNm.toStdString());
 		NLGEORGES::CForm *parentForm = dynamic_cast<NLGEORGES::CForm*>(uParentForm);
 		NLGEORGES::CForm *mainForm = static_cast<NLGEORGES::CForm*>(m_form);
 
-		CGeorgesFormProxyModel * proxyModel = dynamic_cast<CGeorgesFormProxyModel *>(m_ui.treeView->model());
+		CGeorgesFormModel *model = dynamic_cast<CGeorgesFormModel *>(m_ui.treeView->model());
-		CGeorgesFormModel *model = dynamic_cast<CGeorgesFormModel *>(proxyModel->sourceModel());
 
 		if(parentForm)
 		{
@@ -291,11 +277,11 @@ namespace GeorgesQt
 				if (parentForm->Elements.FormDfn ==  mainForm->Elements.FormDfn)
 				{
 					// This is the parent form selector
-					if(!mainForm->insertParent(mainForm->getParentCount(),parentFormNm.toUtf8(), parentForm))
+					if(!mainForm->insertParent(mainForm->getParentCount(),parentFormNm.toStdString().c_str(), parentForm))
-						nlwarning("Failed to add parent form: %s", parentFormNm.toUtf8().constData());
+						nlwarning("Failed to add parent form: %s", parentFormNm.toStdString().c_str());
 					else
 					{
-						nlinfo("Successfullyadded parent form: %s", parentFormNm.toUtf8().constData());
+						nlinfo("Successfullyadded parent form: %s", parentFormNm.toStdString().c_str());
 						model->addParentForm(parentFormNm);
 					}
 				}
@@ -317,7 +303,7 @@ namespace GeorgesQt
 	{
 
 		NLMISC::COFile file;
-        std::string s = NLMISC::CPath::lookup(loadedForm.toUtf8().constData(), false);
+		std::string s = NLMISC::CPath::lookup(loadedForm.toStdString(), false);
 		if(file.open (s))
 		{
 		    try
@@ -394,19 +380,15 @@ namespace GeorgesQt
 
 	void CGeorgesTreeViewDialog::doubleClicked ( const QModelIndex & index ) 
 	{
-		// TODO: this is messy :( perhaps this can be done better
+		//CGeorgesFormModel *model = 
-		CGeorgesFormProxyModel * proxyModel = 
+		//	dynamic_cast<CGeorgesFormModel *>((m_ui.treeView->model());
-			dynamic_cast<CGeorgesFormProxyModel *>(m_ui.treeView->model());
-		CGeorgesFormModel *model = 
-			dynamic_cast<CGeorgesFormModel *>(proxyModel->sourceModel());
-		QModelIndex sourceIndex = proxyModel->mapToSource(index);
 
-		CFormItem *item = model->getItem(sourceIndex);
+		//CFormItem *item = model->getItem(index);
 
-		if (item->parent() && item->parent()->data(0) == "parents")
+		//if (item->parent() && item->parent()->data(0) == "parents")
-		{
+		//{
-			Q_EMIT changeFile(CPath::lookup(item->data(0).toString().toUtf8().constData(),false).c_str());
+		//	Q_EMIT changeFile(CPath::lookup(item->data(0).toString().toStdString(),false).c_str());
-		}
+		//}
 
 		//// col containing additional stuff like icons
 		//if (index.column() == 2) 
@@ -415,7 +397,7 @@ namespace GeorgesQt
 		//	CFormItem *item = m->getItem(in2);
 		//	QString value = item->data(1).toString();
 
-		//	QString path = CPath::lookup(value.toUtf8(),false).c_str();
+		//	QString path = CPath::lookup(value.toStdString(),false).c_str();
 
 		//	if(value.contains(".tga") || value.contains(".png")) 
 		//	{
@@ -443,7 +425,7 @@ namespace GeorgesQt
 		//			{
 		//				Modules::objViewInt()->resetScene();
 		//				//Modules::config().configRemapExtensions();
-		//				Modules::objViewInt()->loadMesh(path.toUtf8(),"");
+		//				Modules::objViewInt()->loadMesh(path.toStdString(),"");
 		//			}
 		//			return;
 		//		}
@@ -472,12 +454,12 @@ namespace GeorgesQt
 
 	void CGeorgesTreeViewDialog::filterRows()
 	{
-		CGeorgesFormProxyModel * mp = dynamic_cast<CGeorgesFormProxyModel *>(m_ui.treeView->model());
+		//CGeorgesFormProxyModel * mp = dynamic_cast<CGeorgesFormProxyModel *>(m_ui.treeView->model());
-		CGeorgesFormModel *m = dynamic_cast<CGeorgesFormModel *>(mp->sourceModel());
+		//CGeorgesFormModel *m = dynamic_cast<CGeorgesFormModel *>(mp->sourceModel());
-		if (m) {
+		//if (m) {
-			m->setShowParents(m_ui.checkBoxParent->isChecked());
+		//	m->setShowParents(m_ui.checkBoxParent->isChecked());
-			m->setShowDefaults(m_ui.checkBoxDefaults->isChecked());
+		//	m->setShowDefaults(m_ui.checkBoxDefaults->isChecked());
-		}
+		//}
 	}
 
 	void CGeorgesTreeViewDialog::showContextMenu(const QPoint &pos)
@@ -492,109 +474,128 @@ namespace GeorgesQt
 		if(!index.isValid())
 			return;
 
-		CGeorgesFormProxyModel * mp = dynamic_cast<CGeorgesFormProxyModel *>(m_ui.treeView->model());
+		CGeorgesFormModel *m = dynamic_cast<CGeorgesFormModel *>(m_ui.treeView->model());
-		CGeorgesFormModel *m = dynamic_cast<CGeorgesFormModel *>(mp->sourceModel());
-		QModelIndex sourceIndex = mp->mapToSource(index);
 
-		if (m) 
+		if(m) 
 		{
-			
+			CFormItem *item = m->getItem(index);
-			CFormItem *item = m->getItem(sourceIndex);
 
 			// Right click on the "parents" item
-			if (item->data(0) == "parents")
+		//	if (item->data(0) == "parents")
-				contextMenu.addAction("Add parent...");
+		//		contextMenu.addAction("Add parent...");
-			// Right click on a parent item
+		//	// Right click on a parent item
-			else if(item->parent() && item->parent()->data(0) == "parents")
+		//	else if(item->parent() && item->parent()->data(0) == "parents")
+		//	{
+		//		contextMenu.addAction("Add parent...");
+		//		contextMenu.addAction("Remove parent");
+		//	}
+			if(item->isArray())
 			{
-				contextMenu.addAction("Add parent...");
+                contextMenu.addAction("Append array entry...");
-				contextMenu.addAction("Remove parent");
 			}
-			else if(item->getFormElm()->isArray())
+			else if(item->isArrayMember())
-				contextMenu.addAction("Add array entry...");
-			else if(item->getFormElm()->isStruct())
 			{
-				QMenu *structContext = new QMenu("Add struct element...", this);
+				contextMenu.addAction("Delete array entry...");
-				contextMenu.addMenu(structContext);
+				contextMenu.addAction("Insert after array entry...");
+			}
+		//	else if(item->getFormElm()->isStruct())
+		//	{
+		//		QMenu *structContext = new QMenu("Add struct element...", this);
+		//		contextMenu.addMenu(structContext);
 
-				NLGEORGES::UFormDfn *defn = item->getFormElm()->getStructDfn();
+		//		NLGEORGES::UFormDfn *defn = item->getFormElm()->getStructDfn();
-				if(defn)
+		//		if(defn)
+		//		{
+		//			for(uint defnNum=0; defnNum < defn->getNumEntry(); defnNum++)
+		//			{
+		//				std::string entryName;
+		//				std::string dummy;
+		//				UFormElm::TWhereIsValue *whereV = new UFormElm::TWhereIsValue;
+		//				bool result = defn->getEntryName(defnNum, entryName);
+		//				bool result2 = item->getFormElm()->getValueByName(dummy, entryName.c_str(), NLGEORGES::UFormElm::Eval, whereV);
+
+		//				
+		//				if(result2 && *whereV != UFormElm::ValueForm)
+		//				{
+		//					structContext->addAction(entryName.c_str());
+		//				}
+		//				delete whereV;
+		//			}
+		//		}
+		//	}
+		//	else if(item->getFormElm()->isAtom() && item->valueFrom() == NLGEORGES::UFormElm::ValueForm)
+		//		contextMenu.addAction("Revert to parent/default...");
+
+            QAction *selectedItem = contextMenu.exec(QCursor::pos());
+            if(selectedItem)
             {
-					for(uint defnNum=0; defnNum < defn->getNumEntry(); defnNum++)
+                if(selectedItem->text() == "Append array entry...")
                 {
-						std::string entryName;
-						std::string dummy;
-						UFormElm::TWhereIsValue *whereV = new UFormElm::TWhereIsValue;
-						bool result = defn->getEntryName(defnNum, entryName);
-						bool result2 = item->getFormElm()->getValueByName(dummy, entryName.c_str(), NLGEORGES::UFormElm::Eval, whereV);
 
 
-						if(result2 && *whereV != UFormElm::ValueForm)
+                } // Append an array entry...
+                else if(selectedItem->text() == "Delete array entry...")
                 {
-							structContext->addAction(entryName.c_str());
-						}
-						delete whereV;
-					}
-				}
-			}
-			else if(item->getFormElm()->isAtom() && item->valueFrom() == NLGEORGES::UFormElm::ValueForm)
-				contextMenu.addAction("Revert to parent/default...");
 
-			QAction *selectedItem = contextMenu.exec(globalPos);
+                }
-			if(selectedItem)
+                else if(selectedItem->text() == "Insert after array entry...")
-			{
-				if(selectedItem->text() == "Add parent...")
                 {
-					// Get the file extension of the form so we can build a dialog pattern.
-					QString file = m_form->getFilename().c_str();
-					file = file.remove(0,file.indexOf(".")+1);
-					QString filePattern = "Parent Sheets (*."+file+")";
 
-					nlinfo("parent defn name '%s'", file.toUtf8().constData());
+                }
-					QStringList fileNames = QFileDialog::getOpenFileNames(this, tr("Select parent sheets..."), m_lastSheetDir, filePattern);
-					if(!fileNames.isEmpty())
-					{
-						Q_FOREACH(QString fileToParent, fileNames)
-						{
-							// Get just the filename. Georges doesn't want the path.
-							QFileInfo pathInfo( fileToParent );
-							QString tmpFileName( pathInfo.fileName() );
 
-							nlinfo("requesting to add parent form '%s'", tmpFileName.toUtf8().constData());
 
-							// Call to add the form and load it into the Georges form.
+		//		if(selectedItem->text() == "Add parent...")
-							addParentForm(tmpFileName);
+		//		{
+		//			// Get the file extension of the form so we can build a dialog pattern.
+		//			QString file = m_form->getFilename().c_str();
+		//			file = file.remove(0,file.indexOf(".")+1);
+		//			QString filePattern = "Parent Sheets (*."+file+")";
+		//			
+		//			nlinfo("parent defn name '%s'", file.toStdString().c_str());
+		//			QStringList fileNames = QFileDialog::getOpenFileNames(this, tr("Select parent sheets..."), m_lastSheetDir, filePattern);
+		//			if(!fileNames.isEmpty())
+		//			{
+		//				Q_FOREACH(QString fileToParent, fileNames)
+		//				{
+		//					// Get just the filename. Georges doesn't want the path.
+		//					QFileInfo pathInfo( fileToParent );
+		//					QString tmpFileName( pathInfo.fileName() );
 
-							// Save the file lookup path for future dialog boxes.
+		//					nlinfo("requesting to add parent form '%s'", tmpFileName.toStdString().c_str());
-							m_lastSheetDir = pathInfo.absolutePath();
+		//					
-						}						
+		//					// Call to add the form and load it into the Georges form.
-					}
+		//					addParentForm(tmpFileName);
-					m_ui.treeView->expandAll();
-				}
-				else if(selectedItem->text() == "Remove parent")
-				{
-					NLGEORGES::CForm *form = static_cast<NLGEORGES::CForm *>(m_form);
-					QString parentFileName = item->data(0).toString();
 
-					for(uint num = 0; num < form->getParentCount(); num++)
+		//					// Save the file lookup path for future dialog boxes.
-					{
+		//					m_lastSheetDir = pathInfo.absolutePath();
-						QString curParentName = form->getParent(num)->getFilename().c_str();
+		//				}						
-						if(parentFileName == curParentName)
+		//			}
-						{
+		//			m_ui.treeView->expandAll();
-							form->removeParent(num);
+		//		}
-							m->removeParentForm(parentFileName);
+		//		else if(selectedItem->text() == "Remove parent")
-							break;
+		//		{
-						}
+		//			NLGEORGES::CForm *form = static_cast<NLGEORGES::CForm *>(m_form);
-					}
+		//			QString parentFileName = item->data(0).toString();
 
-					m_ui.treeView->expandAll();
+		//			for(uint num = 0; num < form->getParentCount(); num++)
-				}
+		//			{
+		//				QString curParentName = form->getParent(num)->getFilename().c_str();
+		//				if(parentFileName == curParentName)
+		//				{
+		//					form->removeParent(num);
+		//					m->removeParentForm(parentFileName);
+		//					break;
+		//				}
+		//			}
+
+		//			m_ui.treeView->expandAll();
+		//		}
 
             } // if selected context menu item is valid.
 		} // if 'm' model valid.
 
-		if(structContext)
+		//if(structContext)
-			delete structContext;
+		//	delete structContext;
 	}
 
 } /* namespace GeorgesQt */

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georges_treeview_form.ui

@@ -6,8 +6,8 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>400</width>
+    <width>564</width>
-    <height>300</height>
+    <height>525</height>
    </rect>
   </property>
   <property name="sizePolicy">
@@ -18,8 +18,8 @@
   </property>
   <property name="minimumSize">
    <size>
-    <width>199</width>
+    <width>280</width>
-    <height>165</height>
+    <height>242</height>
    </size>
   </property>
   <property name="focusPolicy">
@@ -29,9 +29,21 @@
    <string/>
   </property>
   <widget class="QWidget" name="dockWidgetContents">
-   <layout class="QGridLayout" name="gridLayout">
+   <property name="sizePolicy">
+    <sizepolicy hsizetype="Expanding" vsizetype="Expanding">
+     <horstretch>0</horstretch>
+     <verstretch>0</verstretch>
+    </sizepolicy>
+   </property>
+   <layout class="QGridLayout" name="gridLayout_5">
     <item row="0" column="0">
      <widget class="QTabWidget" name="treeViewTabWidget">
+      <property name="sizePolicy">
+       <sizepolicy hsizetype="Expanding" vsizetype="Expanding">
+        <horstretch>0</horstretch>
+        <verstretch>0</verstretch>
+       </sizepolicy>
+      </property>
       <property name="tabPosition">
        <enum>QTabWidget::West</enum>
       </property>
@@ -39,20 +51,18 @@
        <number>0</number>
       </property>
       <widget class="QWidget" name="form_tab">
-       <property name="focusPolicy">
-        <enum>Qt::NoFocus</enum>
-       </property>
        <attribute name="title">
         <string>Form</string>
        </attribute>
-       <layout class="QGridLayout" name="gridLayout_3">
+       <layout class="QHBoxLayout" name="horizontalLayout">
-        <property name="bottomMargin">
+        <item>
-         <number>0</number>
+         <widget class="QSplitter" name="splitter">
+          <property name="orientation">
+           <enum>Qt::Horizontal</enum>
           </property>
-        <item row="0" column="0" colspan="4">
           <widget class="QTreeView" name="treeView">
            <property name="sizePolicy">
-           <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
+            <sizepolicy hsizetype="Expanding" vsizetype="Preferred">
              <horstretch>0</horstretch>
              <verstretch>0</verstretch>
             </sizepolicy>
@@ -67,32 +77,14 @@
             <bool>true</bool>
            </property>
           </widget>
-        </item>
+          <widget class="QtTreePropertyBrowser" name="propertiesBrowser" native="true">
-        <item row="1" column="0">
+           <property name="sizePolicy">
-         <widget class="QCheckBox" name="checkBoxParent">
+            <sizepolicy hsizetype="Minimum" vsizetype="Preferred">
-          <property name="text">
+             <horstretch>0</horstretch>
-           <string>Parent</string>
+             <verstretch>0</verstretch>
+            </sizepolicy>
            </property>
           </widget>
-        </item>
-        <item row="1" column="2">
-         <spacer name="horizontalSpacer">
-          <property name="orientation">
-           <enum>Qt::Horizontal</enum>
-          </property>
-          <property name="sizeHint" stdset="0">
-           <size>
-            <width>40</width>
-            <height>20</height>
-           </size>
-          </property>
-         </spacer>
-        </item>
-        <item row="1" column="1">
-         <widget class="QCheckBox" name="checkBoxDefaults">
-          <property name="text">
-           <string>Defaults</string>
-          </property>
          </widget>
         </item>
        </layout>
@@ -126,8 +118,14 @@
    </layout>
   </widget>
  </widget>
- <resources>
+ <customwidgets>
-  <include location="georges_editor.qrc"/>
+  <customwidget>
- </resources>
+   <class>QtTreePropertyBrowser</class>
+   <extends>QWidget</extends>
+   <header>qttreepropertybrowser.h</header>
+   <container>1</container>
+  </customwidget>
+ </customwidgets>
+ <resources/>
  <connections/>
 </ui>

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georgesform_model.cpp

@@ -14,17 +14,20 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-#include "stdpch.h"
 #include "georgesform_model.h"
-#include "formitem.h"
+
+// System Includes
+#include <libxml/parser.h>
 
 // NeL includes
 #include <nel/misc/types_nl.h>
 #include <nel/misc/rgba.h>
 #include <nel/misc/path.h>
+#include <nel/misc/debug.h>
 #include <nel/georges/u_form_elm.h>
 #include <nel/georges/u_type.h>
 #include <nel/georges/u_form_dfn.h>
+#include <nel/georges/form.h>
 
 // Qt includes
 #include <QColor>
@@ -37,18 +40,22 @@
 #include <QLabel>
 #include <QPixmap>
 
+// project includes
+#include "formitem.h"
+#include "georges_editor_form.h"
+#include "actions.h"
+
 using namespace NLGEORGES;
 
 namespace GeorgesQt 
 {
 
-	CGeorgesFormModel::CGeorgesFormModel(UFormElm *rootElm, QMap< QString, QStringList> deps,
+    CGeorgesFormModel::CGeorgesFormModel(UForm *form, QMap< QString, QStringList> deps,
         QString comment, QStringList parents, bool *expanded, QObject *parent) : QAbstractItemModel(parent) 
     {
-		
+        m_form = form;
         m_rootData << "Value" << "Data" << "Extra";// << "Type";
-		m_rootElm = rootElm;
+        m_rootItem = new CFormItem();
-		m_rootItem = new CFormItem(m_rootElm, m_rootData);
         m_dependencies = deps;
         m_comments = comment;
         m_parents = parents;
@@ -76,143 +83,11 @@ namespace GeorgesQt
             {
                 return getItem(p_index)->data(p_index.column());
             }
-		case Qt::BackgroundRole:
-			{
-				QBrush defaultBrush = QBrush(QColor(255,0,0,30));
-				QBrush parentBrush  = QBrush(QColor(0,255,0,30));
-
-				// if elm not existing it must be some kind of default or type value
-				if(!getItem(p_index)->getFormElm())
-				{
-					return defaultBrush;
-				}
-
-				// else it might be some parent elm
-				switch (getItem(p_index)->nodeFrom())
-				{
-				case NLGEORGES::UFormElm::NodeParentForm:
-					{
-						return parentBrush;
-					}
-				case NLGEORGES::UFormElm::NodeForm:
-					{
-						switch (getItem(p_index)->valueFrom())
-						{
-						case NLGEORGES::UFormElm::ValueParentForm:
-							{
-								return parentBrush;
-							}
-						default:
-							{
-								// parent status test kindof ugly, testing only 2 steps deep
-								// only needed for colorization as treeview default hides childs
-								// when parent is hidden
-								CFormItem *parent = getItem(p_index)->parent();
-								if (parent)
-								{
-									if (parent->nodeFrom() == NLGEORGES::UFormElm::NodeParentForm)
-									{
-										return parentBrush;
-									}
-
-									CFormItem *parentParent = parent->parent();
-									if (parentParent)
-									{
-										if (parentParent->nodeFrom() == NLGEORGES::UFormElm::NodeParentForm)
-										{
-											return parentBrush;
-										}
-									} // endif parentParent
-								} // endif parent
-							} // end default
-						} // end switch valueFrom
-					} // end case nodeForm
-				} // end switch nodeFrom
-				return QVariant();
-			}
 		case Qt::DecorationRole:
 			{
-				if (p_index.column() == 2) 
+				// Based on the _Type return a QIcon from resources.
-				{
+				CFormItem *item = getItem(p_index);
-					//p_index.
+				return item->getItemImage(m_rootItem);
-					QModelIndex in = index(p_index.row(),p_index.column()-1,p_index.parent());
-					CFormItem *item = getItem(in);
-
-					QString value = item->data(1).toString();
-					//QString path = NLMISC::CPath::lookup(value.toUtf8().constData(),false).c_str();
-
-					/*if (value.contains(".shape")) 
-					{
-						if (Modules::objViewInt())
-						{
-							QIcon *icon = Modules::objViewInt()->saveOneImage(value.toUtf8().constData());
-							if (icon)
-							{
-								if(icon->isNull())
-									return QIcon(":/images/pqrticles.png");
-								else
-									return QIcon(*icon);
-							}
-							else
-							{
-								return QIcon();
-							}
-						}
-					}*/
-					if(value.contains(".tga") || value.contains(".png")) 
-					{
-						QString path = NLMISC::CPath::lookup(value.toUtf8().constData(),false).c_str();
-						if(path.isEmpty())
-						{
-							path = ":/images/pqrticles.png";
-						}
-						return QIcon(path);
-					}
-				}
-				return QVariant();
-				break;
-			}
-		case Qt::ToolTipRole:
-			{
-				if (p_index.column() == 2) 
-				{
-					QModelIndex in = index(p_index.row(),p_index.column()-1,p_index.parent());
-					CFormItem *item = getItem(in);
-					QString value = item->data(1).toString();
-					
-					/*if (value.contains(".shape")) 
-					{
-						if (Modules::objViewInt()) 
-						{
-							QIcon *icon = Modules::objViewInt()->saveOneImage(value.toUtf8().constData());
-							if (icon)
-							{
-								if(icon->isNull())
-									return QIcon(":/images/pqrticles.png");
-								else
-									return QIcon(*icon);
-							}
-							else
-							{
-								return QIcon();
-							}
-						}
-					}*/
-					if(value.contains(".tga") || value.contains(".png"))
-					{
-						QString path = NLMISC::CPath::lookup(value.toUtf8().constData(),false).c_str();
-						if(path.isEmpty())
-						{
-							path = ":/images/pqrticles.png";
-						}
-
-						QString imageTooltip = QString("<img src='%1'>").arg(path);
-						
-						return imageTooltip;
-					}
-				}
-				return QVariant();
-				break;
 			}
         default:
             return QVariant();
@@ -234,20 +109,23 @@ namespace GeorgesQt
 
     /******************************************************************************/
 
-	bool CGeorgesFormModel::setData(const QModelIndex &index, const QVariant &value,
+    bool CGeorgesFormModel::setData(const QModelIndex &index, const QVariant &value, int role) 
-		int role) 
     {
 
         if (role != Qt::EditRole)
             return false;
 		
 		CFormItem *item = getItem(index);
-		bool result = item->setData(index.column(), value);
+
+		if(!item->isEditable(index.column()))
+			return false;
+
+		GeorgesEditorForm::UndoStack->push(new CUndoFormArrayRenameCommand(this,item,value));
 
         Q_EMIT dataChanged(index, index);
 
         //setupModelData();
-		return result;
+        return true;
     }
 
     /******************************************************************************/
@@ -259,8 +137,12 @@ namespace GeorgesQt
 
         Qt::ItemFlags returnValue = Qt::ItemIsSelectable | Qt::ItemIsEnabled;
 
-		if(index.column() == 1)
+		CFormItem *item = getItem(index);
+		
+        if(item->isEditable(index.column()))
+		{		
 			returnValue |= Qt::ItemIsEditable;
+		}
 
         return returnValue;
 
@@ -331,6 +213,14 @@ namespace GeorgesQt
             return QModelIndex();
     }
 
+	QModelIndex CGeorgesFormModel::index(int row, int column, CFormItem *item) const
+	{
+		if(item == m_rootItem)
+			return QModelIndex();
+
+		return createIndex(row, 0, item);
+	}
+
     /******************************************************************************/
 
     QModelIndex CGeorgesFormModel::parent(const QModelIndex &index) const
@@ -378,241 +268,205 @@ namespace GeorgesQt
     /******************************************************************************/
 
     void CGeorgesFormModel::loadFormData(UFormElm *root, CFormItem *parent) {
-
-		if (!root) 
 		return;
-
-		uint num = 0;
-		
-
-		if (root->isStruct()) 
-		{
-			//((CFormElm*)root)->getForm()->getComment();
-			uint structSize = 0;
-			root->getStructSize(structSize);
-			while (num < structSize) 
-			{
-				UFormElm::TWhereIsNode *whereN = new UFormElm::TWhereIsNode;
-				UFormElm::TWhereIsValue *whereV = new UFormElm::TWhereIsValue;
-				// Append a new item to the current parent's list of children.
-				std::string elmName;
-				if(root->getStructNodeName(num, elmName)) 
-				{
-					QList<QVariant> columnData;
-					//QVariant value;
-					std::string value;
-					//NLMISC::CRGBA value_color;
-					//uint value_uint;
-					//sint value_sint;
-					//double value_double;
-					QString elmtType;
-					UFormElm *elmt = 0;
-					if(root->getNodeByName(&elmt, elmName.c_str(),  whereN, true)) 
-					{
-						if (elmt) 
-						{
-							if (elmt->isArray())
-								elmtType = "Array";
-							if (elmt->isStruct())
-								elmtType = "Struct";
-							if (elmt->isAtom())
-							{
-								elmtType = "Atom";
-								uint numDefinitions = 0;
-								const UType *type = elmt->getType();
-								if (type) 
-								{
-									numDefinitions = type->getNumDefinition();
-									root->getValueByName(value, elmName.c_str(),UFormElm::Eval,whereV);
-									switch (type->getType()) 
-									{
-									case UType::UnsignedInt:
-									{
-										uint v;
-										NLMISC::fromString(value, v);
-										value = NLMISC::toString(v);
-										elmtType.append("_uint");break;
-									}
-									case UType::SignedInt:
-									{
-										sint v;
-										NLMISC::fromString(value, v);
-										value = NLMISC::toString(v);
-										elmtType.append("_sint");break;
-									}
-									case UType::Double:
-										float v;
-										NLMISC::fromString(value, v);
-										value = NLMISC::toString(v);
-										elmtType.append("_double");break;
-									case UType::String:
-										elmtType.append("_string");break;
-									case UType::Color:
-										elmtType.append("_color");break;
-									default:
-										elmtType.append("_unknownType");
-									}
     }
-								else
+
+    CFormItem *CGeorgesFormModel::addStruct (CFormItem *parent,
+                                             NLGEORGES::CFormElmStruct *_struct,
+                                             NLGEORGES::CFormDfn *parentDfn,
+                                             const char *name,
+                                             uint structId,
+                                             const char *formName,
+                                             uint slot)
+{
+        // The form pointer
+        NLGEORGES::CForm *formPtr = static_cast<NLGEORGES::CForm*>(m_form);
+
+        // Add the new node
+        CFormItem *newNode = parent->add(CFormItem::Form, name, structId, formName, slot, m_form);
+
+        // Can be NULL in virtual DFN
+        if (parentDfn)
         {
-									elmtType.append("_noType");
+                // Get the parents
-								}
+                std::vector<NLGEORGES::CFormDfn *> arrayDfn;
+                arrayDfn.reserve (parentDfn->countParentDfn ());
+                parentDfn->getParentDfn (arrayDfn);
 
-								if (numDefinitions) 
+                // For each child
+                uint elm=0;
+                for (uint dfn=0; dfn<arrayDfn.size(); dfn++)
                 {
-									std::string l, v;
+                        for (uint i=0; i<arrayDfn[dfn]->getNumEntry (); i++)
-									QString tmpLabel, tmpValue;
-									for (uint i = 0; i < numDefinitions; i++) 
                         {
-										type->getDefinition(i,l,v);
+                                // Get the entry ref
-										tmpLabel = l.c_str();
+                                NLGEORGES::CFormDfn::CEntry &entry = arrayDfn[dfn]->getEntry (i);
-										tmpValue = v.c_str();
+
-										if (type->getType() == UType::SignedInt) 
+                                // Form entry name
+                                std::string entryName = (std::string (formName)+"."+entry.getName ());
+
+                                // Is a struct ?
+                                if ( (entry.getType () == NLGEORGES::UFormDfn::EntryDfn) || (entry.getType () == NLGEORGES::UFormDfn::EntryVirtualDfn) )
                                 {
-											if (QString("%1").arg(value.c_str()).toDouble() == tmpValue.toDouble()) {
+                                        // Is an array of struct ?
-												value = l;
+                                        if (entry.getArrayFlag ())
-												break;
-											}
-										}
-										if (type->getType() == UType::String) 
                                         {
-											if (QString(value.c_str()) == tmpValue) 
+                                                // Get it from the form
+                                                CFormElmArray *nextArray = NULL;
+                                                if (_struct && _struct->Elements[elm].Element)
+                                                        nextArray = NLMISC::safe_cast<NLGEORGES::CFormElmArray*> (_struct->Elements[elm].Element);
+
+                                                // Else, get it from the parent if we are not a virtual DFN (don't inheritate)
+
+                                                // todo array of virtual struct
+                                                if (!nextArray && (entry.getType () != NLGEORGES::UFormDfn::EntryVirtualDfn) )
                                                 {
-												value = l;
+                                                        // For each parent form
-												break;
+                                                        for (uint parent=0; parent<formPtr->getParentCount (); parent++)
-											}
+                                                        {
+                                                                // Get the node by name
+                                                                NLGEORGES::UFormElm *uNode;
+                                                                if (formPtr->getParent (parent)->getRootNode ().getNodeByName (&uNode, entryName.c_str(), NULL, false) && uNode)
+                                                                {
+                                                                        nextArray = NLMISC::safe_cast<NLGEORGES::CFormElmArray*> (uNode);
                                 }
                                                         }
                                                 }
+
+                                                // Add the new struct
+                                                addArray (newNode, nextArray, entry.getDfnPtr (), entry.getName().c_str(), elm, entryName.c_str (), slot);
                                         }
-							if (elmt->isVirtualStruct())
+                                        else
                                         {
-								root->getValueByName(value, elmName.c_str(),UFormElm::Eval,whereV);
+                                                // Add it
-								elmtType = "VirtualStruct";
+                                                NLGEORGES::CFormElmStruct *nextForm = NULL;
-							}
+
-							switch (*whereN) 
+                                                // Get it from the form
+                                                if (_struct && _struct->Elements[elm].Element)
+                                                        nextForm = NLMISC::safe_cast<NLGEORGES::CFormElmStruct*> (_struct->Elements[elm].Element);
+
+                                                // Else, get it from the parent
+                                                if (!nextForm)
                                                 {
-							case UFormElm::NodeForm:
+                                                        // For each parent form
-								elmtType.append("_fromForm");       break;
+                                                        for (uint parent=0; parent<formPtr->getParentCount (); parent++)
-							case UFormElm::NodeParentForm:
+                                                        {
-								elmtType.append("_fromParentForm"); break;
+                                                                // Get the node by name
-							case UFormElm::NodeDfn:
+                                                                NLGEORGES::UFormElm *uNode;
-								elmtType.append("_isDFN");          break;
+                                                                if (formPtr->getParent (parent)->getRootNode ().getNodeByName (&uNode, entryName.c_str(), NULL, false) && uNode)
-							case UFormElm::NodeType:
+                                                                {
-								elmtType.append("_isType");         break;
+                                                                        nextForm = NLMISC::safe_cast<NLGEORGES::CFormElmStruct*> (uNode);
-							default:
-								elmtType.append("_noNode");
-							}
-							switch (*whereV) 
-							{
-							case UFormElm::ValueForm:
-								elmtType.append("_formValue");   break;
-							case UFormElm::ValueParentForm:
-								elmtType.append("_parentValue"); break;
-							case UFormElm::ValueDefaultDfn:
-								elmtType.append("_dfnValue");    break;
-							case UFormElm::ValueDefaultType:
-								elmtType.append("_typeValue");   break;
-							default:
-								elmtType.append("_noValue");
                                                                 }
-							columnData << QString(elmName.c_str()) << QString(value.c_str()) << "";// << elmtType;
-							parent->appendChild(new CFormItem(elmt, columnData, parent, *whereV, *whereN));
-							//if (parents.last()->childCount() > 0) {
-							//	parents << parents.last()->child(parents.last()->childCount()-1);
-							//}
-							loadFormData(elmt, parent->child(parent->childCount()-1));
                                                         }
-						else
-						{
-							// add Defaults
-							// TODO: spams warnings for non ATOM values but i dont get type of non existing nodes
-							bool success = root->getValueByName(value, elmName.c_str(),UFormElm::Eval,whereV);
-							switch (*whereN) 
-							{
-							case UFormElm::NodeForm:
-								elmtType.append("_fromForm");       break;
-							case UFormElm::NodeParentForm:
-								elmtType.append("_fromParentForm"); break;
-							case UFormElm::NodeDfn:
-								elmtType.append("_isDFN");          break;
-							case UFormElm::NodeType:
-								elmtType.append("_isType");         break;
-							default:
-								elmtType.append("_noNode");
-							}
-							switch (*whereV) 
-							{
-							case UFormElm::ValueForm:
-								elmtType.append("_formValue");   break;
-							case UFormElm::ValueParentForm:
-								elmtType.append("_parentValue"); break;
-							case UFormElm::ValueDefaultDfn:
-								elmtType.append("_dfnValue");    break;
-							case UFormElm::ValueDefaultType:
-								elmtType.append("_typeValue");   break;
-							default:
-								elmtType.append("_noValue");
                                                 }
 
-							columnData << QString(elmName.c_str()) << QString(value.c_str()) << "";// << elmtType;
+                                                // Virtual Dfn pointer
-							parent->appendChild(new CFormItem(elmt, columnData, parent, *whereV, *whereN));
+                                                NLGEORGES::CFormElmVirtualStruct *vStruct = ((entry.getType () == NLGEORGES::UFormDfn::EntryVirtualDfn) && nextForm) ?
+                                                        NLMISC::safe_cast<NLGEORGES::CFormElmVirtualStruct*> (nextForm) : NULL;
+
+                                                NLGEORGES::CFormDfn *tmpDfn = vStruct ?
+                                                            ((NLGEORGES::CFormDfn*)vStruct->FormDfn) : entry.getDfnPtr();
+                                                // Add the new struct
+                                                addStruct (newNode, nextForm, tmpDfn, entry.getName().c_str(), elm, entryName.c_str(), slot);
                                         }
                                 }
-					else 
+                                // Array of type ?
+                                else if ( entry.getArrayFlag () )
                                 {
-						nlinfo("getNodeByName returned false");
+                                        NLGEORGES::CFormElmArray *nextArray = NULL;
+
+                                        // Get it from the form
+                                        if (_struct && _struct->Elements[elm].Element)
+                                                nextArray = NLMISC::safe_cast<NLGEORGES::CFormElmArray*> (_struct->Elements[elm].Element);
+
+                                        // Else, get it from the parent
+                                        if (!nextArray)
+                                        {
+                                                // For each parent form
+                                                for (uint parent=0; parent<formPtr->getParentCount (); parent++)
+                                                {
+                                                        // Get the node by name
+                                                        NLGEORGES::UFormElm *uNode;
+                                                        if (formPtr->getParent (parent)->getRootNode ().getNodeByName (&uNode, entryName.c_str(), NULL, false) && uNode)
+                                                        {
+                                                                nextArray = NLMISC::safe_cast<NLGEORGES::CFormElmArray*> (uNode);
                                                         }
                                                 }
-				num++;
                                         }
+
+                                        // Add the new array
+                                        addArray ( newNode, nextArray, NULL, entry.getName().c_str(), elm, entryName.c_str(), slot );
                                 }
-		if (root->isArray())
+
-		{
+                                // Next element
-			uint arraySize = 0;
+                                elm++;
-			root->getArraySize(arraySize);
+                        }
-			while (num < arraySize)
+                }
+        }
+
+        return newNode;
+}
+
+// ***************************************************************************
+
+CFormItem *CGeorgesFormModel::addArray(CFormItem *parent,
+                                       NLGEORGES::CFormElmArray *array,
+                                       NLGEORGES::CFormDfn *rootDfn,
+                                       const char *name,
+                                       uint structId,
+                                       const char *formName,
+                                       uint slot)
+{
+        // Add the new node
+        CFormItem *newNode = parent->add (CFormItem::Form, name, structId, formName, slot, m_form);
+
+        // The array exist
+        if (array)
         {
-				std::string elmName;
+                // For each array element
-				if(root->getArrayNodeName(elmName, num))
+                for (uint elm=0; elm<array->Elements.size(); elm++)
                 {
-					QList<QVariant> columnData;
+                        // The form name
-					std::string value;
+                        char formArrayElmName[512];
-					QString elmtType;
+                        NLMISC::smprintf (formArrayElmName, 512, "%s[%d]", formName, elm);
 
-					UFormElm *elmt = 0;
+                        // The name
-					if(root->getArrayNode(&elmt,0) && elmt) 
+                        char formArrayName[512];
+                        if (array->Elements[elm].Name.empty ())
                         {
-						if (elmt->isArray())
+                                NLMISC::smprintf (formArrayName, 512, "#%d", elm);
-							elmtType = "Array";
-						if (elmt->isStruct()) {
-							elmtType = "Struct";
                         }
-						if (elmt->isAtom()) 
+                        else
                         {
-							elmt->getValue(value);
+                                NLMISC::smprintf (formArrayName, 512, "%s", array->Elements[elm].Name.c_str());
-							elmtType = "Atom";
                         }
-						if (elmt->isVirtualStruct())
-							elmtType = "VirtualStruct";
 
-						elmtType.append("_arrayValue");
+                        // Is a struct
-						columnData << QString(elmName.c_str()) << QString(value.c_str()) << "";// << elmtType;
+                        if (rootDfn)
-						parent->appendChild(new CFormItem(elmt, columnData, parent));
+                        {
-						loadFormData(elmt, parent->child(parent->childCount()-1));
+                                // Get struct ptr
-					}
+                                NLGEORGES::CFormElmStruct *elmPtr =  array->Elements[elm].Element ? static_cast<NLGEORGES::CFormElmStruct*>(array->Elements[elm].Element) : NULL;
+                                addStruct (newNode, elmPtr, rootDfn, formArrayName, elm, formArrayElmName, slot);
                         }
-				num++;
+                        else
+                        {
+                                NLGEORGES::CFormElmArray *elmPtr = array->Elements[elm].Element ? static_cast<NLGEORGES::CFormElmArray*>(array->Elements[elm].Element) : NULL;
+                                newNode->add (CFormItem::Form, formArrayName, elm, formArrayElmName, slot, m_form);
                         }
                 }
         }
 
+        return newNode;
+}
+
+
+
     /******************************************************************************/
 
     void CGeorgesFormModel::loadFormHeader() 
     {
 
-		if (m_parents.size())
+ /*       if (m_parents.size())
         {
             CFormItem *fi_pars = new CFormItem(m_rootElm, QList<QVariant>() << "parents" << "" << "", m_rootItem);
             m_rootItem->appendChild(fi_pars);
@@ -621,7 +475,7 @@ namespace GeorgesQt
             {
                 fi_pars->appendChild(new CFormItem(m_rootElm, QList<QVariant>() << str << "" << "", fi_pars));
             }
-		}
+        }*/
 
         /*QStringList dfns = _dependencies["dfn"];
         QStringList typs = _dependencies["typ"];
@@ -661,8 +515,11 @@ namespace GeorgesQt
 
     void CGeorgesFormModel::setupModelData()
     {
-		loadFormHeader();
+        m_rootElm = &((NLGEORGES::CForm*)m_form)->Elements;
-		loadFormData(m_rootElm, m_rootItem);
+        NLGEORGES::CFormElmStruct *rootstruct = &((NLGEORGES::CForm*)m_form)->Elements;
+        //loadFormHeader();
+        addStruct(m_rootItem, rootstruct, rootstruct->FormDfn, "Content", 0xffffffff, "", 0);
+        //loadFormData(m_rootElm, m_rootItem);
     }
 
     /******************************************************************************/
@@ -684,7 +541,7 @@ namespace GeorgesQt
         beginResetModel();
         m_parents.push_back(parentForm);
         delete m_rootItem;
-		m_rootItem = new CFormItem(m_rootElm, m_rootData);
+        m_rootItem = new CFormItem();
         setupModelData();
         endResetModel();
     }
@@ -695,7 +552,7 @@ namespace GeorgesQt
         m_parents.removeOne(parentForm);
 
         delete m_rootItem;
-		m_rootItem = new CFormItem(m_rootElm, m_rootData);
+        m_rootItem = new CFormItem();
         setupModelData();
         endResetModel();
     }

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georgesform_model.h

@@ -27,6 +27,10 @@
 
 namespace NLGEORGES {
 	class UFormElm;
+	class UForm;
+    class CFormElmStruct;
+    class CFormDfn;
+    class CFormElmArray;
 }
 
 namespace GeorgesQt 
@@ -36,9 +40,8 @@ namespace GeorgesQt
 
 	class CGeorgesFormModel : public QAbstractItemModel 
 	{
-		
 	public:
-		CGeorgesFormModel(NLGEORGES::UFormElm *root, QMap< QString, QStringList> deps,
+		CGeorgesFormModel(NLGEORGES::UForm *form, QMap< QString, QStringList> deps,
 			QString comment, QStringList parents, bool* expanded, QObject *parent = 0);
 		~CGeorgesFormModel();
 
@@ -47,6 +50,7 @@ namespace GeorgesQt
 		Qt::ItemFlags flags(const QModelIndex &index) const;
 		QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const;
 		QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const;
+		QModelIndex index(int row, int column, CFormItem *item) const;
 		QModelIndex parent(const QModelIndex &index) const;
 		int rowCount(const QModelIndex &parent = QModelIndex()) const;
 		int columnCount(const QModelIndex &parent = QModelIndex()) const;
@@ -60,11 +64,22 @@ namespace GeorgesQt
 		void removeParentForm(QString parentForm);
         NLGEORGES::UFormElm *getRootForm() { return m_rootElm; }
 
+        CFormItem *addStruct (CFormItem *parent, NLGEORGES::CFormElmStruct *_struct, NLGEORGES::CFormDfn *parentDfn,
+                              const char *name, uint structId, const char *formName, uint slot);
+
+        CFormItem *addArray(CFormItem *parent, NLGEORGES::CFormElmArray *array, NLGEORGES::CFormDfn *rootDfn,
+                            const char *name, uint structId, const char *formName, uint slot);
+
+		void emitDataChanged(const QModelIndex &index)
+		{ 
+			Q_EMIT dataChanged(index, index); 
+		}
 	private:
 		void setupModelData();
 		void loadFormData(NLGEORGES::UFormElm *rootElm, CFormItem *parent);
 		void loadFormHeader();
 
+		NLGEORGES::UForm*		m_form;
 		CFormItem*                  m_rootItem;
         NLGEORGES::UFormElm*        m_rootElm;
 		QList<QVariant>				m_rootData;

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georgesform_proxy_model.cpp

@@ -14,15 +14,17 @@
 // You should have received a copy of the GNU Affero General Public License
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-#include "stdpch.h"
-#include "georgesform_proxy_model.h"
-#include "formitem.h"
-#include "georgesform_model.h"
-
 // NeL includes
 #include <nel/misc/debug.h>
 #include <nel/georges/u_form_elm.h>
 
+// project includes
+#include "formitem.h"
+#include "georgesform_proxy_model.h"
+#include "georgesform_model.h"
+
+#if 0
+
 namespace GeorgesQt 
 {
 
@@ -78,4 +80,5 @@ namespace GeorgesQt
 	}
 } /* namespace GeorgesQt */
 
+#endif // 0
 /* end of file */

code/nel/tools/3d/object_viewer_qt/src/plugins/georges_editor/georgesform_proxy_model.h

@@ -20,6 +20,7 @@
 // Qt includes
 #include <QSortFilterProxyModel>
 
+#if 0
 namespace GeorgesQt 
 {
 
@@ -41,5 +42,5 @@ namespace GeorgesQt
 	};/* class CGeorgesFormProxyModel */
 
 } /* namespace GeorgesQt */
-
+#endif // 0
 #endif // GEORGESFORM_PROXY_MODEL_H

code/nel/tools/3d/object_viewer_qt/src/plugins/object_viewer/main_window.cpp

@@ -66,7 +66,7 @@ CMainWindow::CMainWindow(QWidget *parent)
 	  _isGraphicsInitialized(false),
 	  _isGraphicsEnabled(false),
 	  _isSoundInitialized(false),
-	  _isSoundEnabled(true),
+	  _isSoundEnabled(false), // MTR workaround for sheet id nonsense
 	  _GraphicsViewport(NULL),
 	  _lastDir("."),
 	  _mouseMode(NL3D::U3dMouseListener::edit3d)