We shouldn't set up a generated or newly compiled shader program if we already have one ( set up from outside the driver for example ).

--HG--
branch : gsoc2013-dfighter

code/nel/src/3d/driver/opengl3/driver_opengl.h

@@ -708,6 +708,14 @@ private:
 	friend class					CVertexProgamDrvInfosGL3;
 
 private:
+	/// Simply sets the current programs to NULL
+	void nullPrograms()
+	{
+		currentProgram.vp = NULL;
+		currentProgram.pp = NULL;
+		currentProgram.gp = NULL;
+	}
+
 	// Version of the driver. Not the interface version!! Increment when implementation of the driver change.
 	static const uint32			ReleaseVersion;
 

code/nel/src/3d/driver/opengl3/driver_opengl_program.cpp

@@ -512,13 +512,19 @@ namespace NL3D
 		sp = shaderCache.findShader( desc );
 
 		if( !sp.empty() )
+		{
+			if( currentProgram.vp == NULL )
 			{
 				if( !activeVertexProgram( sp.vp ) )
 					return false;
+			}
 
+			if( currentProgram.pp == NULL )
+			{
 				if( !activePixelProgram( sp.pp ) )
 					return false;
 			}
+		}
 		else
 		{
 			std::string vs;
@@ -565,6 +571,8 @@ namespace NL3D
 				return false;
 			}
 
+			if( currentProgram.vp == NULL )
+			{
 				if( !activeVertexProgram( vp ) )
 				{
 					delete vp;
@@ -573,7 +581,10 @@ namespace NL3D
 					pp = NULL;
 					return false;
 				}
+			}
 
+			if( currentProgram.pp == NULL )
+			{
 				if( !activePixelProgram( pp ) )
 				{
 					delete vp;
@@ -582,6 +593,7 @@ namespace NL3D
 					pp = NULL;
 					return false;
 				}
+			}
 			
 			sp.vp = vp;
 			sp.pp = pp;
@@ -596,6 +608,9 @@ namespace NL3D
 
 	bool CDriverGL3::setupDynMatProgram( CMaterial& mat, uint pass )
 	{
+		if( ( currentProgram.vp != NULL ) && ( currentProgram.pp != NULL ) )
+			return true;
+
 		CDynMaterial *m = mat.getDynMat();
 		const SRenderPass *rp = m->getPass( pass );
 		std::string shaderRef;
@@ -606,15 +621,16 @@ namespace NL3D
 		if( !usrShaderManager->getShader( shaderRef, &prg ) )
 			return false;
 		
-		CVertexProgram *vp = new CVertexProgram();
-		CPixelProgram *pp = new CPixelProgram();
-
 		std::string shaderSource;
 		std::string log;
 		std::string name;
+
+		if( currentProgram.vp == NULL )
+		{
 			prg.getVP( shaderSource );
 			prg.getName( name );
 
+			CVertexProgram *vp = new CVertexProgram();		
 			{
 				IProgram::CSource *src = new IProgram::CSource();
 				src->Profile = IProgram::glsl330v;			
@@ -626,10 +642,26 @@ namespace NL3D
 			if( !compileVertexProgram( vp ) )
 			{
 				delete vp;
-			delete pp;
 				return false;
 			}
 
+			if( !activeVertexProgram( vp ) )
+			{
+				delete vp;
+				return false;
+			}
+
+			if( currentProgram.dynmatVP != NULL )
+				delete currentProgram.dynmatVP;
+			currentProgram.dynmatVP = vp;
+
+		}
+
+		if( currentProgram.pp == NULL )
+		{
+		
+			CPixelProgram *pp = new CPixelProgram();
+
 			prg.getFP( shaderSource );
 			{
 				IProgram::CSource *src = new IProgram::CSource();
@@ -641,33 +673,22 @@ namespace NL3D
 		
 			if( !compilePixelProgram( pp ) )
 			{
-			delete vp;
-			delete pp;
-			return false;
-		}
-
-		if( !activeVertexProgram( vp ) )
-		{
-			delete vp;
 				delete pp;
 				return false;
 			}
 
 			if( !activePixelProgram( pp ) )
 			{
-			delete vp;
 				delete pp;
 				return false;
 			}
 
-		if( currentProgram.dynmatVP != NULL )
-			delete currentProgram.dynmatVP;
-		currentProgram.dynmatVP = vp;
-
 			if( currentProgram.dynmatPP != NULL )
 				delete currentProgram.dynmatPP;
 			currentProgram.dynmatPP = pp;
 
+		}
+
 		return true;
 	}
 

code/nel/src/3d/driver/opengl3/driver_opengl_rendering.cpp

@@ -73,6 +73,8 @@ bool CDriverGL3::renderLines(CMaterial& mat, uint32 firstIndex, uint32 nlines)
 	_PrimitiveProfileIn.NLines+= nlines;
 	_PrimitiveProfileOut.NLines+= nlines;
 
+	nullPrograms();
+
 	return true;
 }
 
@@ -127,6 +129,8 @@ bool CDriverGL3::renderTriangles(CMaterial& mat, uint32 firstIndex, uint32 ntris
 	_PrimitiveProfileIn.NTriangles+= ntris;
 	_PrimitiveProfileOut.NTriangles+= ntris * nPass;
 
+	nullPrograms();
+
 	return true;
 }
 
@@ -160,6 +164,8 @@ bool CDriverGL3::renderSimpleTriangles(uint32 firstTri, uint32 ntris)
 	_PrimitiveProfileIn.NTriangles+= ntris;
 	_PrimitiveProfileOut.NTriangles+= ntris;
 
+	nullPrograms();
+
 	return true;
 }
 
@@ -201,6 +207,8 @@ bool CDriverGL3::renderRawPoints(CMaterial& mat, uint32 startIndex, uint32 numPo
 	_PrimitiveProfileIn.NPoints+= numPoints;
 	_PrimitiveProfileOut.NPoints+= numPoints * nPass;
 
+	nullPrograms();
+
 	return true;
 }
 
@@ -242,6 +250,8 @@ bool CDriverGL3::renderRawLines(CMaterial& mat, uint32 startIndex, uint32 numLin
 	_PrimitiveProfileIn.NLines  += numLines ;
 	_PrimitiveProfileOut.NLines += numLines  * nPass;
 
+	nullPrograms();
+
 	return true;
 }
 
@@ -285,6 +295,8 @@ bool CDriverGL3::renderRawTriangles(CMaterial& mat, uint32 startIndex, uint32 nu
 	_PrimitiveProfileIn.NTriangles  += numTris ;
 	_PrimitiveProfileOut.NTriangles += numTris  * nPass;
 
+	nullPrograms();
+
 	return true;
 }
 
@@ -408,6 +420,8 @@ bool CDriverGL3::renderRawQuads(CMaterial& mat, uint32 startIndex, uint32 numQua
 	_PrimitiveProfileIn.NQuads  += numQuads ;
 	_PrimitiveProfileOut.NQuads += numQuads  * nPass;
 
+	nullPrograms();
+
 	return true;
 }