Hide quality indicator on item if equal to 1 #47

If the item is quality 1, it is unnecessary to show the quality. See screenshot of items with quality 1 that don't need to show quality

If the item is quality 1, it is unnecessary to show the quality. See screenshot of items with quality 1 that don't need to show quality ![thumb-Clipboard_-_January_27__2022_12_40_PM](/uploads/3c131b90a0913824c1bba20bf0eb72d9/thumb-Clipboard_-_January_27__2022_12_40_PM.png)

assigned to @bensaine

could be done like this. Also fixes #46

![image](/uploads/9206f426c461e8398a7873e4244eae02/image.png) could be done like this. Also fixes #46

Seems like an optimal solution. Do you think it would be better if the buff icon would go to the right of the quantity indicator if quantity > 1 (between quality and quantity)?

This arrangement would be weird. It also would not work for 10+ count.

![image](/uploads/1c6657e9fd45978ae67ae7de1af2637d/image.png) This arrangement would be weird. It also would not work for 10+ count.

Agreed, very weird

This might be indeed the best

This might be indeed the best ![image](/uploads/9f84dc604b0ce90e4390561001e159a9/image.png)

created merge request !41 to address this issue

mentioned in merge request !41

marked this issue as related to #46

Careful, here we are talking about hiding quality indicator. I will reassign your merge to the other issue.

Careful, here we are talking about hiding **quality** indicator. I will reassign your merge to the other issue.

Oops, I missed that.

Not sure if item quality 1 should be hidden. There is cosmetic/teleport/service family items that have quality hidden as those its meaningless.

Oops, I missed that. Not sure if item quality 1 should be hidden. There is cosmetic/teleport/service family items that have quality hidden as those its meaningless.

See marauder crystal, Zig item, crystallized spells, all of those, I'm not sure the quality of 1 is relevant. But yes, maybe armour and weapons, tools, materials, it is relevant. Move branch to https://gitlab.com/ryzom/ryzom-core/-/tree/46-rework-item-buff-icon-placement btw.

I think current logic of 'hide if one of this family' should be reversed and 'show if > 1x or in one of this family'.

This would always show q1 for those family type where its important and hide q1 by default for everything else.

This would also allow to show q2+ on family types that currently would have it hidden.

I think current logic of 'hide if one of this family' should be reversed and 'show if > 1x or in one of this family'. This would always show q1 for those family type where its important and hide q1 by default for everything else. This would also allow to show q2+ on family types that currently would have it hidden.

I will be pushing this into '1x stack count fix' branch in
https://gitlab.com/ryzom/ryzom-core/-/merge_requests/43 because both are in same file and merge will have conflicts if done in separate branch.

I will be pushing this into '1x stack count fix' branch in https://gitlab.com/ryzom/ryzom-core/-/merge_requests/43 because both are in same file and merge will have conflicts if done in separate branch.

mentioned in merge request !43

If changes in !43 will make some icon quality to show where it did not before (and its > 1), then its probably something that should be fixed in server data if possible.

Labels Milestones

Hide quality indicator on item if equal to 1 #47