From 4c74d1393170efafc55c2f3316cfa72f05cdbbfb Mon Sep 17 00:00:00 2001
From: kaetemi <kaetemi@gmail.com>
Date: Mon, 11 Nov 2019 13:35:30 +0800
Subject: [PATCH] Fix bitbucket/ryzomcore/#340, #341,#342

---
 .../src/interface_v3/inventory_manager.cpp    |  2 +-
 .../client/src/interface_v3/lua_ihm_ryzom.cpp | 46 +++++++++----------
 code/ryzom/client/src/user_entity.cpp         |  6 +--
 3 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/code/ryzom/client/src/interface_v3/inventory_manager.cpp b/code/ryzom/client/src/interface_v3/inventory_manager.cpp
index 78966338a..996f91514 100644
--- a/code/ryzom/client/src/interface_v3/inventory_manager.cpp
+++ b/code/ryzom/client/src/interface_v3/inventory_manager.cpp
@@ -286,7 +286,7 @@ void CItemInfoCache::debugItemInfoCache() const
 {
 	nlinfo("ItemInfoCache: %d entries", _ItemInfoCacheMap.size());
 	uint count = 0;
-	for (auto it = _ItemInfoCacheMap.begin(); it != _ItemInfoCacheMap.end(); ++it)
+	for (TItemInfoCacheMap::const_iterator it = _ItemInfoCacheMap.begin(); it != _ItemInfoCacheMap.end(); ++it)
 	{
 		uint32 serial = (it->first >> 32) & 0xFFFFFFFF;
 		uint32 created = it->first & 0xFFFFFFFF;
diff --git a/code/ryzom/client/src/interface_v3/lua_ihm_ryzom.cpp b/code/ryzom/client/src/interface_v3/lua_ihm_ryzom.cpp
index 789e33618..824db6ade 100644
--- a/code/ryzom/client/src/interface_v3/lua_ihm_ryzom.cpp
+++ b/code/ryzom/client/src/interface_v3/lua_ihm_ryzom.cpp
@@ -4240,30 +4240,30 @@ int CLuaIHMRyzom::displayChatMessage(CLuaState &ls)
 	if (ls.type(2) == LUA_TSTRING)
 	{
 		std::string input = toLower(ls.toString(2));
-		std::unordered_map<std::string, std::string> sParam;
-		// input should match chat_group_filter sParam
-		sParam.insert(make_pair(string("around"), string(dbPath+":SAY")));
-		sParam.insert(make_pair(string("region"), string(dbPath+":REGION")));
-		sParam.insert(make_pair(string("guild"), string(dbPath+":CLADE")));
-		sParam.insert(make_pair(string("team"), string(dbPath+":GROUP")));
-		sParam.insert(make_pair(string("universe"), string(dbPath+":UNIVERSE_NEW")));
-		for (const auto& db : sParam)
+		if (input == "around")
 		{
-			if (db.first.c_str() == input)
-			{
-				prop.readRGBA(db.second.c_str(), " ");
-				if (input == "around")
-					ci.AroundMe.displayMessage(ucstring(msg), prop.getRGBA());
-				if (input == "region")
-					ci.Region.displayMessage(ucstring(msg), prop.getRGBA());
-				if (input == "universe")
-					ci.Universe.displayMessage(ucstring(msg), prop.getRGBA());
-				if (input == "guild")
-					ci.Guild.displayMessage(ucstring(msg), prop.getRGBA());
-				if (input == "team")
-					ci.Team.displayMessage(ucstring(msg), prop.getRGBA());
-				break;
-			}
+			prop.readRGBA(std::string(dbPath + ":SAY").c_str(), " ");
+			ci.AroundMe.displayMessage(ucstring(msg), prop.getRGBA());
+		}
+		else if (input == "region")
+		{
+			prop.readRGBA(std::string(dbPath + ":REGION").c_str(), " ");
+			ci.Region.displayMessage(ucstring(msg), prop.getRGBA());
+		}
+		else if (input == "universe")
+		{
+			prop.readRGBA(std::string(dbPath + ":UNIVERSE_NEW").c_str(), " ");
+			ci.Universe.displayMessage(ucstring(msg), prop.getRGBA());
+		}
+		else if (input == "guild")
+		{
+			prop.readRGBA(std::string(dbPath + ":CLADE").c_str(), " ");
+			ci.Guild.displayMessage(ucstring(msg), prop.getRGBA());
+		}
+		else if (input == "team")
+		{
+			prop.readRGBA(std::string(dbPath + ":GROUP").c_str(), " ");
+			ci.Team.displayMessage(ucstring(msg), prop.getRGBA());
 		}
 	}
 	if (ls.type(2) == LUA_TNUMBER)
diff --git a/code/ryzom/client/src/user_entity.cpp b/code/ryzom/client/src/user_entity.cpp
index fd1670da0..395d5b698 100644
--- a/code/ryzom/client/src/user_entity.cpp
+++ b/code/ryzom/client/src/user_entity.cpp
@@ -3108,9 +3108,9 @@ void CUserEntity::rollDice(sint16 min, sint16 max, bool local)
 		sint16 roll = min + (sint16)dice->rand(max-min);
 
 		ucstring msg = CI18N::get("msgRollDiceLocal");
-		strFindReplace(msg, "%min", std::to_string(min));
-		strFindReplace(msg, "%max", std::to_string(max));
-		strFindReplace(msg, "%roll", std::to_string(roll));
+		strFindReplace(msg, "%min", toString(min));
+		strFindReplace(msg, "%max", toString(max));
+		strFindReplace(msg, "%roll", toString(roll));
 
 		CInterfaceManager *pIM= CInterfaceManager::getInstance();