From 0b503e352b97b782dd03c2b4b6858b9992d4f3a0 Mon Sep 17 00:00:00 2001
From: Nimetu <nimetu@gmail.com>
Date: Sun, 26 Sep 2021 21:59:53 +0300
Subject: [PATCH] Fix htmlEscape function from deadlocking

---
 nel/include/nel/gui/html_element.h |  2 +-
 nel/src/gui/html_element.cpp       | 39 ++++++++++++++++--------------
 2 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/nel/include/nel/gui/html_element.h b/nel/include/nel/gui/html_element.h
index cc59d2126..9a26938af 100644
--- a/nel/include/nel/gui/html_element.h
+++ b/nel/include/nel/gui/html_element.h
@@ -76,7 +76,7 @@ namespace NLGUI
 		void reindexChilds();
 
 		// escape text tag or attribute value
-		std::string htmlEscape(std::string val, bool isAttribute = false) const;
+		std::string htmlEscape(const std::string &val) const;
 
 		// serialize element attributes as string
 		std::string serializeAttributes() const;
diff --git a/nel/src/gui/html_element.cpp b/nel/src/gui/html_element.cpp
index 8eb706cc9..a8038be7d 100644
--- a/nel/src/gui/html_element.cpp
+++ b/nel/src/gui/html_element.cpp
@@ -142,26 +142,29 @@ namespace NLGUI
 	}
 
 	// ***************************************************************************
-	std::string CHtmlElement::htmlEscape(std::string val, bool isAttribute) const
+	std::string CHtmlElement::htmlEscape(const std::string &val) const
 	{
-		static const std::string searchReplace[] = {
-			"&", "&amp;",
-			"<", "&lt;",
-			">", "&gt;",
-			"\xA0", "&nbsp;",
-		};
-		
-		for(uint i = 0; i < (sizeof(searchReplace) / sizeof(searchReplace[0])); i+=2)
-			val = strFindReplaceAll(val, searchReplace[i], searchReplace[i+1]);
-
-		if (isAttribute)
+		if (val.find_first_of("\"'&<>\xA0") == std::string::npos)
+			return val;
+
+		std::string ret;
+		// resize is quaranteed, make room for some free replacements
+		ret.reserve(val.size() + 24);
+		for(size_t pos = 0; pos != val.size(); pos++)
 		{
-			static const std::string q = "\"";
-			static const std::string quot = "&quot;";
-			val = strFindReplaceAll(val, q, quot);
+			switch(val[pos])
+			{
+				case '"': ret.append("&quot;"); break;
+				case '\'': ret.append("&apos;"); break;
+				case '&': ret.append("&amp;"); break;
+				case '<': ret.append("&lt;"); break;
+				case '>': ret.append("&gt;"); break;
+				case '\xA0': ret.append("&nbsp;"); break;
+				default : ret.append(&val[pos],1); break;
+			}
 		}
 
-		return val;
+		return ret;
 	}
 
 	// ***************************************************************************
@@ -179,13 +182,13 @@ namespace NLGUI
 					{
 						result += " ";
 					}
-					result += htmlEscape(*it2, true);
+					result += htmlEscape(*it2);
 				}
 				result += "\"";
 			}
 			else
 			{
-				result += " " + it->first + "=\"" + htmlEscape(it->second, true) + "\"";
+				result += " " + it->first + "=\"" + htmlEscape(it->second) + "\"";
 			}
 		}
 		return result;